Modify the UA stylesheet to allow <dialog popup>
#35652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Aug 26, 2022
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3856639
branch
2 times, most recently
from
6a3968e
to
657eddb
Compare
This CL does two main things:
1. Convert the :-internal-popup-hidden to
:-internal-popup-opening-or-open
2. Add/modify rules for both dialog and [popup] so that they don't
add display:none when a <dialog popup> is either open as a
dialog or pop-up.
See this issue for details:
openui/open-ui#520
Bug: 1307772
Change-Id: I751f6991a988a58032cebd52f289e5468140ce79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3856639
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1040576}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-3856639
branch
from
657eddb
to
e272099
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL does two main things:
:-internal-popup-opening-or-open
add display:none when a <dialog popup> is either open as a
dialog or pop-up.
See this issue for details:
openui/open-ui#520
Bug: 1307772
Change-Id: I751f6991a988a58032cebd52f289e5468140ce79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3856639
Commit-Queue: Mason Freed <[email protected]>
Auto-Submit: Mason Freed <[email protected]>
Reviewed-by: David Baron <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1040576}