Make togglePopover return a boolean #40409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 6, 2023
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4595402
branch
from
211cec0
to
730aff7
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4595402
branch
from
730aff7
to
1cef790
Compare
This patch makes togglePopover return true if it opens the popover or false if it closes it. HTML spec issue: whatwg/html#9043 Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595402 Commit-Queue: Joey Arhar <[email protected]> Reviewed-by: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/main@{#1159748}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-4595402
branch
from
1cef790
to
7399080
Compare
annevk
pushed a commit
to whatwg/html
that referenced
this pull request
Jun 20, 2023
rubberyuzu
pushed a commit
to rubberyuzu/html
that referenced
this pull request
Jul 20, 2023
rubberyuzu
pushed a commit
to rubberyuzu/html
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes togglePopover return true if it opens the popover or
false if it closes it.
HTML spec issue: whatwg/html#9043
Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595402
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159748}