Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should togglePopover() return a boolean? #9043

Closed
jakearchibald opened this issue Mar 17, 2023 · 5 comments · Fixed by #9393
Closed

Should togglePopover() return a boolean? #9043

jakearchibald opened this issue Mar 17, 2023 · 5 comments · Fixed by #9393
Labels
addition/proposal New features or enhancements topic: popover The popover attribute and friends

Comments

@jakearchibald
Copy link
Contributor

jakearchibald commented Mar 17, 2023 •
edited
Loading

https://html.spec.whatwg.org/multipage/popover.html#dom-togglepopover

The only other toggle I know on the platform is domToken.toggle(), which also features the force param. It returns a boolean depending on the resulting state.
@jakearchibald jakearchibald added the topic: popover The popover attribute and friends label Mar 17, 2023
@jakearchibald
Copy link
Contributor Author

jakearchibald commented Mar 23, 2023 •
edited
Loading

Open UI resolution: yes

Minutes: https://www.w3.org/2023/03/23-openui-minutes.html#t04

@annevk annevk added addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest and removed normative change labels Apr 20, 2023
@annevk
Copy link
Member

annevk commented Apr 20, 2023

This seems like a reasonable change that I suspect WebKit would be willing to make. @nt1m?

@nt1m
Copy link
Member

nt1m commented Apr 20, 2023

This sounds reasonable.

@nt1m
Copy link
Member

nt1m commented Jun 6, 2023

@mfreed7 @josepharhar Would one of you be willing to drive this change?

josepharhar added a commit to josepharhar/html that referenced this issue Jun 6, 2023
@josepharhar
Make togglePopover return a boolean
cc2f307 
This PR makes togglePopover return true if it opens the popover or false
if it closes it.

Fixes whatwg#9043
@josepharhar josepharhar mentioned this issue Jun 6, 2023
Merged
4 tasks
@josepharhar
Copy link
Contributor

Sure, I opened a PR: #9393

Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 6, 2023
@josepharhar @chromium-wpt-export-bot
Make togglePopover return a boolean
211cec0 
This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 7, 2023
@josepharhar @chromium-wpt-export-bot
Make togglePopover return a boolean
730aff7 
This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
@nt1m nt1m removed the needs implementer interest Moving the issue forward requires implementers to express interest label Jun 8, 2023
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 19, 2023
@josepharhar @chromium-wpt-export-bot
Make togglePopover return a boolean
1cef790 
This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
aarongable pushed a commit to chromium/chromium that referenced this issue Jun 19, 2023
@josepharhar
Make togglePopover return a boolean
ba43907 
This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595402
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159748}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 20, 2023
@josepharhar @chromium-wpt-export-bot
Make togglePopover return a boolean
7399080 
This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595402
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159748}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jun 20, 2023
@josepharhar @chromium-wpt-export-bot
Make togglePopover return a boolean
e3da78c 
This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595402
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159748}
annevk pushed a commit that referenced this issue Jun 20, 2023
@josepharhar
Make togglePopover() return a boolean
3824cd6 
Tests: web-platform-tests/wpt#40409.

Fixes #9043.
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jun 28, 2023
@josepharhar @moz-wptsync-bot
Bug 1837092 [wpt PR 40409] - Make togglePopover return a boolean, a=t…
501d653 
…estonly

Automatic update from web-platform-tests
Make togglePopover return a boolean

This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595402
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159748}

--

wpt-commits: e3da78cf0478a6c4fc6c356613579c594b25f244
wpt-pr: 40409
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Jul 1, 2023
@marco-c
Bug 1837092 [wpt PR 40409] - Make togglePopover return a boolean, a=t…
fdbf0ab 
…estonly

Automatic update from web-platform-tests
Make togglePopover return a boolean

This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595402
Commit-Queue: Joey Arhar <jarharchromium.org>
Reviewed-by: Mason Freed <masonfchromium.org>
Cr-Commit-Position: refs/heads/main{#1159748}

--

wpt-commits: e3da78cf0478a6c4fc6c356613579c594b25f244
wpt-pr: 40409

UltraBlame original commit: fba981d6d35bc6fcc925091e0f2ddb9e616fc1e9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Jul 1, 2023
@marco-c
Bug 1837092 [wpt PR 40409] - Make togglePopover return a boolean, a=t…
918ee65 
…estonly

Automatic update from web-platform-tests
Make togglePopover return a boolean

This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595402
Commit-Queue: Joey Arhar <jarharchromium.org>
Reviewed-by: Mason Freed <masonfchromium.org>
Cr-Commit-Position: refs/heads/main{#1159748}

--

wpt-commits: e3da78cf0478a6c4fc6c356613579c594b25f244
wpt-pr: 40409

UltraBlame original commit: fba981d6d35bc6fcc925091e0f2ddb9e616fc1e9
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Jul 1, 2023
@marco-c
Bug 1837092 [wpt PR 40409] - Make togglePopover return a boolean, a=t…
80c75b6 
…estonly

Automatic update from web-platform-tests
Make togglePopover return a boolean

This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595402
Commit-Queue: Joey Arhar <jarharchromium.org>
Reviewed-by: Mason Freed <masonfchromium.org>
Cr-Commit-Position: refs/heads/main{#1159748}

--

wpt-commits: e3da78cf0478a6c4fc6c356613579c594b25f244
wpt-pr: 40409

UltraBlame original commit: fba981d6d35bc6fcc925091e0f2ddb9e616fc1e9
ErichDonGubler pushed a commit to erichdongubler-mozilla/firefox that referenced this issue Jul 5, 2023
@josepharhar @moz-wptsync-bot
Bug 1837092 [wpt PR 40409] - Make togglePopover return a boolean, a=t…
00f2fde 
…estonly

Automatic update from web-platform-tests
Make togglePopover return a boolean

This patch makes togglePopover return true if it opens the popover or
false if it closes it.

HTML spec issue: whatwg/html#9043

Change-Id: I64a1f543cb380fca01866d7b08edc8bb0c3136e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4595402
Commit-Queue: Joey Arhar <[email protected]>
Reviewed-by: Mason Freed <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1159748}

--

wpt-commits: e3da78cf0478a6c4fc6c356613579c594b25f244
wpt-pr: 40409
rubberyuzu pushed a commit to rubberyuzu/html that referenced this issue Jul 20, 2023
@josepharhar
Make togglePopover() return a boolean
b22e6e3 
Tests: web-platform-tests/wpt#40409.

Fixes whatwg#9043.
rubberyuzu pushed a commit to rubberyuzu/html that referenced this issue Jul 21, 2023
@josepharhar
Make togglePopover() return a boolean
98cbe09 
Tests: web-platform-tests/wpt#40409.

Fixes whatwg#9043.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addition/proposal New features or enhancements topic: popover The popover attribute and friends
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make togglePopover return a boolean josepharhar/html
4 participants
@jakearchibald @annevk @nt1m @josepharhar