Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm registry proxy in CI to test publication/installation #3157

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Add npm registry proxy in CI to test publication/installation #3157

merged 2 commits into from
Oct 30, 2019

Conversation

cgewecke
Copy link
Collaborator

(Continuation of #3098)

Adds the ability to publish the monorepo to an ephemeral virtual registry in CI and install Web3's latest state in an arbitrary target project. This lets us run other projects' unit tests to verify that no breaking changes have been introduced.

Includes:

  • npm virtual registry via the verdaccio package
  • uses @truffle/contract as an E2E target

One thing to note about this is that it doesn't work very well when the target requires that installation be done with yarn. (Getting Truffle to work with this format was a little challenging.)

Truffle's tests are run as an "allowed failure" and CI will turn green without waiting for them to finish. This is done because these tests are mostly a pre-publication sanity check which might help us track breaking changes down to a specific PR if they occur.

@cgewecke cgewecke changed the title Add E2E npm registry proxy in CI to test publication/installation Add npm registry proxy in CI to test publication/installation Oct 25, 2019
@cgewecke cgewecke added 1.x 1.0 related issues CI labels Oct 25, 2019
@coveralls
Copy link

coveralls commented Oct 25, 2019

Coverage Status

Coverage remained the same at 84.005% when pulling ab2f84b on cgewecke:tests/e2e-publish into 49f3eac on ethereum:1.x.

@cgewecke cgewecke requested a review from nivida October 28, 2019 21:24
@nivida nivida merged commit 266741c into web3:1.x Oct 30, 2019
This was referenced Oct 31, 2019
@alcuadrado
Copy link

This is great @cgewecke 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants