Fix e2e lerna publish (#3) #3170
Conversation
| @@ -219,6 +219,7 @@ var outputTransactionReceiptFormatter = function (receipt){ | |||
| if(typeof receipt.status !== 'undefined' && receipt.status !== null) { | |||
| receipt.status = Boolean(parseInt(receipt.status)); | |||
| } | |||
| console.log('using new web3 at to format transaction receipt') | |||
There was a problem hiding this comment.
Edit this file to remove this line. It proves that the bundle is being published/used correctly in travis here.
I agree, this is a good idea. |
|
|
||
| fi | ||
|
|
||
| git checkout $BRANCH -- |
There was a problem hiding this comment.
The build is failing here because
- Lerna [won't publish to the virtual registry][1] when the git head is in a detached state.
- It's necessary to explicitly checkout a branch to trick it
- The branch isn't present when a fork's changes are proposed for the upstream
I'm going to resolve this temporarily by merging into a staging branch at web3 to make sure the CI runs as expected here. It would be nice if this ran for outside contributors, but perhaps is not critical that it does either because this kind of test is more of a pre-publication tests that's use internally anyway.
(DO NOT MERGE until making suggested change in the comment below)
Unfortunately #3157 was only ~%25 correct :/
PR fixes several problems:
exec(obviously wrong). I've had to upgrade Lerna to 3.x to get this to work.I've added a 'proof' that this works - there's an incorrect console.log line in
web3-core-helperswhich is printed out while truffle's tests run. So we know their code is exercising the published copy.It needs to be removed before merging..
Lastly, some of Truffle's tests are failing with an error that's already been reported at truffle 2512. I don't think any recent changes here are the cause because they have not updated to 1.2.2 yet.