Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow e2e failures in CI #3530

Merged
merged 5 commits into from
May 22, 2020
Merged

Allow e2e failures in CI #3530

merged 5 commits into from
May 22, 2020

Conversation

ryanio
Copy link
Collaborator

@ryanio ryanio commented May 21, 2020

Description

This PR fixes #3503 by allowing ci jobs to fail by removing continue-on-error.

This PR also tries to fix failures on PRs from forks by removing the git checkout step in e2e.npm.publish.sh since we can use actions/checkout.

More information about the current state and expected outcomes of the ci runs are planned to be documented in #3528.

Type of change

  • CI

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build-all and tested the resulting files from dist folder in a browser.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the live network.

@ryanio ryanio added 1.x 1.0 related issues CI labels May 21, 2020
@coveralls
Copy link

coveralls commented May 21, 2020

Coverage Status

Coverage remained the same at 89.602% when pulling 0428689 on allow-failures-in-ci into 77d4314 on 1.x.

@ryanio ryanio changed the title Allow failures in CI Allow e2e failures in CI May 22, 2020
@cgewecke cgewecke self-requested a review May 22, 2020 03:37
Copy link
Collaborator

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks for figuring this out. 💯

@cgewecke cgewecke merged commit 32c9805 into 1.x May 22, 2020
@cgewecke cgewecke deleted the allow-failures-in-ci branch May 22, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x 1.0 related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write GH Actions "allowed failure" reporter
3 participants