Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow e2e failures in CI #3530

Merged
merged 5 commits into from
May 22, 2020
Merged

Allow e2e failures in CI #3530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e552965
allow failures in ci
ryanio May 21, 2020
9db59ac
test `lerna version` without branch
ryanio May 21, 2020
1da784c
add `fail-fast: false` to e2e matrix
ryanio May 21, 2020
68fadea
skip failing ganache test
ryanio May 21, 2020
0428689
Merge branch '1.x' into allow-failures-in-ci
cgewecke May 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
e2e:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
testCmd:
[
Expand All @@ -60,7 +61,6 @@ jobs:

- run: bash ./scripts/install.sh
- run: bash ./scripts/ci.sh
continue-on-error: ${{ matrix.testCmd == 'e2e_ganache' || matrix.testCmd == 'e2e_mosaic' }}

- name: Send coverage reports to Coveralls
if: env.TEST == 'unit_and_e2e_clients'
Expand All @@ -79,4 +79,3 @@ jobs:
- uses: actions/checkout@v1
- run: bash ./scripts/install.sh
- run: bash ./scripts/ci.sh
continue-on-error: true
15 changes: 10 additions & 5 deletions scripts/e2e.ganache.core.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,17 @@ echo ">>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>"

npm run build

# NB: there's one failing ganache test, which checks
# whether the object returned by the server is an
# instanceof StateManager. Also fails locally & doesn't
# seem web3 related. Skipping it with grep / invert.
# There are two failing ganache tests:
# 1. "should return instance of StateManager on start":
# Checks whether the object returned by the server is an
# instanceof StateManager. Also fails locally & doesn't
# seem web3 related.
# 2. "should handle events properly via the data event handler":
# Upstream issue. Also fails locally & doesn't
# seem web3 related.
# Skipping them with grep / invert.
TEST_BUILD=node npx mocha \
--grep "instance of" \
--grep "should return instance of StateManager on start|should handle events properly via the data event handler" \
--invert \
--check-leaks \
--recursive \
Expand Down
10 changes: 0 additions & 10 deletions scripts/e2e.npm.publish.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,21 +45,11 @@ npm-auth-to-token \
-e [email protected] \
-r http://localhost:4873

# Prep branch for Lerna's git-checks
if [[ $GITHUB_REF = 'refs/pull/'* ]]; then
BRANCH=${GITHUB_HEAD_REF#refs/pull/}
else
BRANCH=${GITHUB_REF#refs/heads/}
fi

git checkout $BRANCH --

# Lerna version
lerna version minor \
--force-publish=* \
--no-git-tag-version \
--no-push \
--allow-branch $BRANCH \
--ignore-scripts \
--yes

Expand Down