Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: custom transaction polling interval (#4584) #4672

Merged
merged 7 commits into from
Jan 14, 2022
Merged

add: custom transaction polling interval (#4584) #4672

merged 7 commits into from
Jan 14, 2022

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Jan 7, 2022 •
edited
Loading

  • Debugging failing Windows test
  • Adds transactionPollingInterval to web3-eth
  • Adds transactionPollingInterval tests

@sirpy @nazarhussain
add: custom transaction polling interval (#4584)
61d5070 
* add: custom transaction polling interval

allow to set via options the interval which polls for TX status

* add: transactionPollingInterval to contract

* add: pass transactionPollingInterval to method

* Update CHANGELOG.md

* add: transactionPollingInterval docs

Co-authored-by: Nazar Hussain <[email protected]>
@spacesailor24 spacesailor24 self-assigned this Jan 7, 2022
@render
Copy link

render bot commented Jan 7, 2022

Your Render PR Server URL is https://web3-js-pr-4672.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-c7bqaqpg7hpbv8633jk0.

@spacesailor24 spacesailor24 mentioned this pull request Jan 7, 2022
Merged
14 tasks
@spacesailor24 spacesailor24 added the 1.x 1.0 related issues label Jan 7, 2022
jdevcs
jdevcs reviewed Jan 7, 2022
View reviewed changes
CHANGELOG.md Outdated
@@ -484,7 +484,8 @@ Released with 1.0.0-beta.37 code base.

### Added
- `maxPriorityFeePerGas` and `maxFeePerGas` added to `Transaction` and `TransactionConfig` interfaces (#4232) (#4585)

- `transactionPollingInterval` added to web3, contract and method constructor options. defaults to 1 second. (#4584)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.7.0 is already frozen under 1.7.0-rc so this change should be under future release instead of 1.7.0

jdevcs
jdevcs requested changes Jan 7, 2022
View reviewed changes
docs/web3-eth.rst Outdated Show resolved Hide resolved
docs/web3-eth-contract.rst Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1699133797

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 467 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-2.2%) to 72.725%
Files with Coverage Reduction New Missed Lines %
packages/web3-core-requestmanager/src/jsonrpc.js 1 88.0%
packages/web3-core-method/lib/index.js 10 93.85%
packages/web3-eth/lib/index.js 13 90.61%
packages/web3-eth-contract/lib/index.js 15 91.94%
packages/web3-core-helpers/src/formatters.js 25 81.07%
packages/web3-core-helpers/src/errors.js 31 4.41%
packages/web3-utils/src/soliditySha3.js 55 5.13%
packages/web3-utils/src/index.js 62 29.31%
packages/web3-utils/src/utils.js 92 12.86%
packages/web3-eth-accounts/src/index.js 163 23.77%
Totals Coverage Status
Change from base Build 1688533323: -2.2%
Covered Lines: 3383
Relevant Lines: 4395
💛 - Coveralls

@spacesailor24 spacesailor24 merged commit b32555c into 1.x Jan 14, 2022
@spacesailor24 spacesailor24 deleted the wyatt/1.x/4584-windows-test-debug branch January 14, 2022 19:09
@nazarhussain nazarhussain mentioned this pull request Jan 21, 2022
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Feb 1, 2022
Closed
This was referenced Feb 11, 2022
Open
Open
Open
Open
Open
Open
This was referenced Feb 11, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 24, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazarhussain nazarhussain nazarhussain approved these changes

@luu-alex luu-alex luu-alex approved these changes

@jdevcs jdevcs jdevcs approved these changes

Assignees

@spacesailor24 spacesailor24

Labels
1.x 1.0 related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spacesailor24 @coveralls @nazarhussain @luu-alex @jdevcs @sirpy