-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: custom transaction polling interval (#4584) #4672
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
61d5070
add: custom transaction polling interval (#4584)
sirpy c72a64d
Add transactionPollingInterval to web3-eth
spacesailor24 b8c8d95
Init transactionPollingInterval tests
spacesailor24 a704f71
Update docs/web3-eth.rst
spacesailor24 1e0070c
Update docs/web3-eth-contract.rst
spacesailor24 509cf84
Merge branch '1.x' into wyatt/1.x/4584-windows-test-debug
spacesailor24 1915a99
Move 4672 change to 1.7.1
spacesailor24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
var chai = require('chai'); | ||
var assert = chai.assert; | ||
var Eth = require('../packages/web3-eth'); | ||
|
||
var eth = new Eth(); | ||
|
||
var setValue = 123; | ||
|
||
describe('web3.eth', function () { | ||
describe('transactionPollingInterval', function () { | ||
it('should check if transactionPollingInterval is set to proper value', function () { | ||
assert.equal(eth.transactionPollingInterval, 1000); | ||
assert.equal(eth.Contract.transactionPollingInterval, 1000); | ||
assert.equal(eth.getCode.method.transactionPollingInterval, 1000); | ||
}); | ||
it('should set transactionPollingInterval for all sub packages is set to proper value, if Eth package is changed', function () { | ||
eth.transactionPollingInterval = setValue; | ||
|
||
assert.equal(eth.transactionPollingInterval, setValue); | ||
assert.equal(eth.Contract.transactionPollingInterval, setValue); | ||
assert.equal(eth.getCode.method.transactionPollingInterval, setValue); | ||
}); | ||
}); | ||
}); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.7.0 is already frozen under 1.7.0-rc so this change should be under future release instead of 1.7.0