Fix and error when trying to get past events by calling contract.getPastEvents or contract.events.allEvents() if there is no matching events.
#6647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Muhammad-Altabba
requested review from
avkos,
jdevcs and
luu-alex
as code owners
Deploying with
|
| Latest commit: |
93d340a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6ae33edc.web3-js-docs.pages.dev |
| Branch Preview URL: | https://6644-calling-contractgetpast.web3-js-docs.pages.dev |
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6647 +/- ##
==========================================
+ Coverage 87.37% 90.87% +3.49%
==========================================
Files 197 214 +17
Lines 7548 8117 +569
Branches 2059 2172 +113
==========================================
+ Hits 6595 7376 +781
+ Misses 953 741 -212
Flags with carried forward coverage won't be shown. Click here to find out more.
|
avkos
requested changes
Dec 7, 2023
avkos
approved these changes
Dec 8, 2023
jdevcs
reviewed
Dec 11, 2023
…teventsallevents-throws-error-subscriptionerror-failed-to-get-past-events-if-there-is-no-matching-events
Muhammad-Altabba
force-pushed
the
6644-calling-contractgetpastevents-or-contracteventsallevents-throws-error-subscriptionerror-failed-to-get-past-events-if-there-is-no-matching-events
branch
from
8ce52a2
to
9d08b3a
Compare
jdevcs
approved these changes
Dec 12, 2023
Muhammad-Altabba
deleted the
6644-calling-contractgetpastevents-or-contracteventsallevents-throws-error-subscriptionerror-failed-to-get-past-events-if-there-is-no-matching-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6644
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.