Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and error when trying to get past events by calling contract.getPastEvents or contract.events.allEvents() if there is no matching events. #6647

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Fix and error when trying to get past events by calling contract.getPastEvents or contract.events.allEvents() if there is no matching events. #6647

merged 7 commits into from
Dec 12, 2023

Commits on Dec 7, 2023

  1. handle the case when getPastEvents does not have any event to return

    @Muhammad-Altabba
    Muhammad-Altabba committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    3904eae View commit details
    Browse the repository at this point in the history

  2. add unit test for contract log subscription

    @Muhammad-Altabba
    Muhammad-Altabba committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    b913075 View commit details
    Browse the repository at this point in the history

  3. update CHANGELOG.md

    @Muhammad-Altabba
    Muhammad-Altabba authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    415f85d View commit details
    Browse the repository at this point in the history

  4. update according to review points

    @Muhammad-Altabba
    Muhammad-Altabba authored Dec 7, 2023
    Configuration menu
    Copy the full SHA
    cbcd4b3 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2023

  1. relocate a block back

    @Muhammad-Altabba
    Muhammad-Altabba authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    50883ff View commit details
    Browse the repository at this point in the history

  2. Merge branch '4.x' into 6644-calling-contractgetpastevents-or-contrac… 

    …teventsallevents-throws-error-subscriptionerror-failed-to-get-past-events-if-there-is-no-matching-events
    @Muhammad-Altabba
    Muhammad-Altabba authored Dec 11, 2023
    Configuration menu
    Copy the full SHA
    9d08b3a View commit details
    Browse the repository at this point in the history

  3. update jest at web3-eth-ens

    @Muhammad-Altabba
    Muhammad-Altabba committed Dec 11, 2023
    Configuration menu
    Copy the full SHA
    93d340a View commit details
    Browse the repository at this point in the history