fix(web3-errors): the undefined data in Eip838ExecutionError #6905
Conversation
Alfxjx
requested review from
avkos,
jdevcs,
luu-alex and
Muhammad-Altabba
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6905 +/- ##
==========================================
+ Coverage 87.37% 91.99% +4.62%
==========================================
Files 197 215 +18
Lines 7548 8172 +624
Branches 2059 2202 +143
==========================================
+ Hits 6595 7518 +923
+ Misses 953 654 -299
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| { | ||
| "cause": undefined, | ||
| "code": undefined, | ||
| "data": undefined, |
There was a problem hiding this comment.
The code was already working when data is undefined. But it does not work when data is null. So, could you please update the tests?
Thanks,
There was a problem hiding this comment.
ok I will look into it and fix.
There was a problem hiding this comment.
Hi @Alfxjx ,
Just to clarify that your code looks great! And what I proposed to update is only your tests. That is to test with null instead of undefined. Please, let me know if you need any help to finish this.
Thanks,
|
@Muhammad-Altabba could you update changelog and merge this PR, as seems @Alfxjx is away. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
|
cc: @mconnelly8 |
|
this PR will be merged into 4.x via: web3:junaid/eip838fix |
…7147) * fix(web3-errors): the undefined data in Eip838ExecutionError (#6905) * fix(web3-errors): handle the undefined data in Eip838ExecutionError constructor(#6433) * doc: update changelog * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Muhammad Altabba <[email protected]> Co-authored-by: Junaid <[email protected]> * changelog update --------- Co-authored-by: Xu Jianxiang <[email protected]> Co-authored-by: Muhammad Altabba <[email protected]> Co-authored-by: Oleksii Kosynskyi <[email protected]>
Description
Fixes #6433
process the undefined data in Eip838ExecutionError constructor to avoid an "read something from undefined" bug.
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.