Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web3-errors): the undefined data in Eip838ExecutionError (#6905) #7147

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Jul 11, 2024

Description

Fixes #6433

process the undefined data in Eip838ExecutionError constructor to avoid an "read something from undefined" bug.

(This PR is created for merging #6905 into 4.x)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

* fix(web3-errors): handle the undefined data in Eip838ExecutionError constructor(#6433)

* doc: update changelog

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: Muhammad Altabba <[email protected]>
Co-authored-by: Junaid <[email protected]>
Copy link

github-actions bot commented Jul 11, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 635.99 kB → 636 kB (+8 B) +0.00%
Changeset
File Δ Size
../web3-errors/lib/commonjs/errors/contract_errors.js 📈 +14 B (+0.17%) 7.97 kB → 7.98 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 616.7 kB → 616.7 kB (+8 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e793cc5 Previous: 463d070 Ratio
processingTx 9330 ops/sec (±3.46%) 9085 ops/sec (±3.80%) 0.97
processingContractDeploy 39389 ops/sec (±7.42%) 39873 ops/sec (±6.00%) 1.01
processingContractMethodSend 16176 ops/sec (±8.93%) 15649 ops/sec (±9.76%) 0.97
processingContractMethodCall 28238 ops/sec (±6.46%) 27135 ops/sec (±6.88%) 0.96
abiEncode 44978 ops/sec (±6.89%) 43610 ops/sec (±6.72%) 0.97
abiDecode 30337 ops/sec (±8.13%) 29967 ops/sec (±8.45%) 0.99
sign 1525 ops/sec (±3.05%) 1496 ops/sec (±3.20%) 0.98
verify 374 ops/sec (±0.44%) 374 ops/sec (±0.41%) 1

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.45%. Comparing base (463d070) to head (e793cc5).

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7147   +/-   ##
=======================================
  Coverage   94.45%   94.45%           
=======================================
  Files         215      215           
  Lines        8391     8391           
  Branches     2313     2313           
=======================================
  Hits         7926     7926           
  Misses        465      465           
Flag Coverage Δ
UnitTests 94.45% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdevcs jdevcs merged commit 6b80cf0 into 4.x Jul 12, 2024
54 checks passed
@jdevcs jdevcs deleted the junaid/eip838fix branch July 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot use 'in' operator to search for 'originalError' in null
3 participants