[NFTCard] : New styles for card #969
Conversation
🦋 Changeset detectedLatest commit: 2a90ba8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| /** | ||
| * set card background color | ||
| */ | ||
| backgroundColor: string; |
There was a problem hiding this comment.
yeah, nice catch 🙌🏻
Will make these new props optional ✅
| /** | ||
| * set border for details section | ||
| */ | ||
| detailsBorder: string | 'none'; |
There was a problem hiding this comment.
this seems strange. maybe it should be optional? but the dev cant even use it to set a border... If its an on / off switch use a boolean like hasBorderStyles. But best DX is to offer a border?: string so the dev can set border: 1px solid color and if its left unset it shows what you have now... or you set current styles as the default value on line 17 of packages/core/src/lib/NftCard/NftCard.tsx
There was a problem hiding this comment.
- Yes this is optional.
- It's not named as
borderbecause this border is for the component inside card. - will remove extra
none✅
|
Have added |
name: 'Pull request'
about: A new pull request
New Pull Request
Checklist
Issue Description
Related issue: #
FILL_THIS_OUTSolution Description