-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFTCard] : New styles for card #969
Changes from 5 commits
5a3b0fb
4eab59c
e9917df
0197dd5
3187f32
b0ae1d0
b7361fa
2710e07
2a90ba8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@web3uikit/core': patch | ||
--- | ||
|
||
Add styles for nft card |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ jobs: | |
- name: Install pnpm | ||
uses: pnpm/[email protected] | ||
with: | ||
version: 7 | ||
version: 7.11.0 | ||
|
||
- name: Install dependencies | ||
run: pnpm install | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ jobs: | |
- name: Install pnpm | ||
uses: pnpm/[email protected] | ||
with: | ||
version: 7 | ||
version: 7.11.0 | ||
|
||
- name: Use Node ${{ matrix.node }} | ||
uses: actions/setup-node@v2 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,7 +21,7 @@ jobs: | |
- name: Install pnpm | ||
uses: pnpm/[email protected] | ||
with: | ||
version: 7 | ||
version: 7.11.0 | ||
|
||
- name: Use Node ${{ matrix.node }} | ||
uses: actions/setup-node@v2 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ jobs: | |
- name: Install pnpm | ||
uses: pnpm/[email protected] | ||
with: | ||
version: 7 | ||
version: 7.11.0 | ||
|
||
- uses: andresz1/size-limit-action@v1 | ||
with: | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ jobs: | |
- name: Install pnpm | ||
uses: pnpm/[email protected] | ||
with: | ||
version: 7 | ||
version: 7.11.0 | ||
|
||
- name: Use Node ${{ matrix.node }} | ||
uses: actions/setup-node@v2 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,4 +38,14 @@ export interface INftCardProps { | |
* custom details component | ||
*/ | ||
customDetails: ReactNode; | ||
|
||
/** | ||
* set card background color | ||
*/ | ||
backgroundColor: string; | ||
|
||
/** | ||
* set border for details section | ||
*/ | ||
detailsBorder: string | 'none'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this seems strange. maybe it should be optional? but the dev cant even use it to set a border... If its an on / off switch use a boolean like hasBorderStyles. But best DX is to offer a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, nice catch 🙌🏻
Will make these new props optional ✅