Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Payment redesign, stripe v3 & wip-google pay #1527

Closed
wants to merge 1 commit into from
Closed

Conversation

odinuge
Copy link
Member

@odinuge odinuge commented Mar 27, 2019

We can get some inspiration here: https://stripe.dev/elements-examples/

Should be more info about payments after the user has paid too.
Screenshot from 2019-03-27 23-31-51

@odinuge
Copy link
Member Author

odinuge commented Mar 28, 2019

This will make payment a lot simpler (still in work) for users to understand. We should look at https://developers.google.com/pay/api/web/guides/brand-guidelines (required if we will use google pay, but they are generally nice). We (HS/Arrkom, @JonasBak) should also write some information about how refunds works (should work). We dont need to implement refunds via lego-webapp, but the user should understand the terms of their payment. Like what happen if you unregister after you have paid.

We should also a add a You have paid 123,--info, together with the date/time and payment method.

@orhanhenrik
Copy link
Member

What happened to the "avregistrer" button styling? Was it like that before?

I agree that there should be more information around terms and feedback on what happened. Since this is regarding payments/money, users will probably be extra concerned as well.

@odinuge
Copy link
Member Author

odinuge commented Mar 28, 2019

Haha, nop. Double WIP-PR with some quick global styling for testing ™️

@LudvigHz
Copy link
Member

LudvigHz commented Sep 5, 2019

I'm thinking we should wait with this until webkom/lego#1631 is done, and we have upgraded the Stripe API. I'm going to have to switch to stripe elements in the PR i'm working on now to get the new API working, so not sure what you want to do with this?

@odinuge
Copy link
Member Author

odinuge commented Oct 1, 2019

Most of this has been cherry-picked or re-implemented in #1590, so ill just close this.

@odinuge odinuge closed this Oct 1, 2019
@SmithPeder SmithPeder deleted the gpay branch August 24, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants