Switch to Stripe Elements and Intents API #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
LudvigHz
changed the title
|
New Payment Form 🔥 🔥 3D secure Error messages delivered by stripe |
LudvigHz
force-pushed
the
stripe-sca
branch
2 times, most recently
from
476d693
to
9648fd7
Compare
LudvigHz
requested review from
kotlarz,
odinuge,
JonasBak,
finnss,
ingraso,
iselinee,
mrfarstad and
SmithPeder
LudvigHz
force-pushed
the
stripe-sca
branch
from
9648fd7
to
b2b34aa
Compare
odinuge
reviewed
Sep 15, 2019
orhanhenrik
reviewed
Sep 24, 2019
odinuge
changed the title
mrfarstad
reviewed
Oct 9, 2019
app/reducers/registrations.js
Outdated
| case Event.SOCKET_PAYMENT.SUCCESS: { | ||
| const registration = normalize(action.payload, registrationSchema) | ||
| .entities.registrations[action.payload.id]; | ||
| if (!registration) { |
There was a problem hiding this comment.
There should be some kind of error handling here
| setSuccess={() => this.setSuccess()} | ||
| setError={error => this.setError(error)} | ||
| setLoading={loading => this.setLoading(loading)} | ||
| ledgend={ |
There was a problem hiding this comment.
LudvigHz
changed the title
New payment flow: 1. Create payment intent in backend and return the client_secret to frontend 2. Use this, and pass all payment details to Stripe.js 3. Stripe handles payment details
You now have a 'start payment' button that creates a payment intent, and the client_secret is sent with Websockets to the client for further action. Also renamed `charge` to `payment`.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on webkom/lego#1669
This PR:
What's missing:
The current plan is to use the synchronous flow as Stripe calls it, which is the easiest method of handling the payments.Stripe recommends using the automatic confirmation method though.I'm thinking we should go the easier way since our payments are so simple, and we wouldn't need webhooks, need feedback on this!I've migrated backend to the synchronous flow automatic confirmation method, but need to test and make sure we go this way before making a PR.I am not able to test this until we upgrade our Stripe API version though. Should be safe to upgrade in a few days!