replace <str>.length with Buffer.byteLength(<str>)

[hulkish]

Some chars represent a byte length greater than 1. This means string length could report incorrect parsedSize, for bundles - if any special chars are used. More on this here.

[EugeneHlushko]

Looks legit, do you think you could add an auto test to cover this case?

[valscion]

Hi, thanks for this PR! @EugeneHlushko has a point — it would be nice if we could have a test to cover this case.

You can take a look into test/stats/with-module-concatenation-info/ how there's both a stats.json generated by webpack and the bundle.js it represents. The expected values webpack-bundle-analyzer would report are in expected-chart-data.js.

This is how the test is ran:

webpack-bundle-analyzer/test/analyzer.js

Lines 31 to 37 in d145284

	it('should support stats files with modules inside `chunks` array', async function () {
	generateReportFrom('with-modules-in-chunks/stats.json');
	const chartData = await getChartData();
	expect(chartData).to.containSubset(
	require('./stats/with-modules-in-chunks/expected-chart-data')
	);
	});

[hulkish]

@valscion can you point me in the right direction for this? Im trying to get an idea of how i am intended to generate the fixture for this test?

[valscion]

The best bet might be to create a small reproduction repository with plain webpack and generate a stats.json object and output bundle from there. Supply that output to the basis of your new test and test that the expected sizes match what you want.

[hulkish]

@valscion that makes sense, thank you.

I guess I was looking for a script that creates one for me, or something lol

[hulkish]

@valscion @EugeneHlushko will this do it?

[th0r]

@hulkish thanks, merged! Sorry for the delay.