Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace <str>.length with Buffer.byteLength(<str>) #223

Merged
merged 2 commits into from
Mar 2, 2019
Merged

replace <str>.length with Buffer.byteLength(<str>) #223

merged 2 commits into from
Mar 2, 2019

Commits on Nov 15, 2018

  1. replace <str>.length with Buffer.byteLength(<str>) 

    Some chars represent a byte length greater than 1. This means string length could report incorrect `statSize` if any special chars are used. More on this [here](https://sankhs.com/2016/03/17/content-length-http-headers/)
    @hulkish
    hulkish authored Nov 15, 2018
    Configuration menu
    Copy the full SHA
    b2fc04c View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2018

  1. added tests for special chars byte length

    Steven Hargrove committed Nov 17, 2018
    Configuration menu
    Copy the full SHA
    0d5824f View commit details
    Browse the repository at this point in the history