-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproduction of excessive tokio polling #284
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change the reflect example will demonstrate excessive polling in the operations task despite not being woken.
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 56.44% 56.38% -0.07%
==========================================
Files 500 500
Lines 47316 47317 +1
Branches 12811 12804 -7
==========================================
- Hits 26708 26679 -29
- Misses 9992 10002 +10
- Partials 10616 10636 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Added tracing of the futures involved in 4c5bbc3 As expected there's some polling at first, but then there's no more:
|
Closing as there's no intent to merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reproduces something weird that I ran across in
tokio-console
. For some reason the taskwebrtc/webrtc/src/peer_connection/operation/mod.rs
Lines 54 to 56 in 5d05b88
seems to be polled extremely excessively by the Tokio runtime, despite it's waker not being woken.
Example screenshot after running for only a few minutes
Generally, the task only gets woken when an operation is queued, as one would expect.
To reproduce
RUSTFLAGS="--cfg tokio_unstable" cargo build --example reflect
from the root--debug
argument when starting the example.tokio-console
Environment
OS: macOS 12.5
Machine: Apple M1 Max Macbook Pro