Skip to content

Commit

Permalink
Merge pull request #11204 from wellcomecollection/tsc-on-all
Browse files Browse the repository at this point in the history
Run `tsc` on all TS repos, trial `path-files` to filter out when they run
  • Loading branch information
rcantin-w authored Sep 30, 2024
2 parents d9c4615 + 30e65be commit 2baa8ca
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 8 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/tsc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,8 @@ jobs:
- name: (Workspaces) yarn tsc
run: yarn install && yarn tsc
- name: (Playwright) yarn tsc
run: cd playwright && yarn install && yarn tsc
run: cd playwright && yarn install && yarn tsc
- name: (Dash) yarn tsc
run: cd dash/webapp && yarn install && yarn tsc
- name: (Updown) yarn tsc
run: cd updown && yarn install && yarn tsc
2 changes: 1 addition & 1 deletion common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"dependencies": {
"@elastic/apm-rum": "^5.12.0",
"@next/bundle-analyzer": "^13.2.3",
"@popperjs/core": "^2.11.7",
"@popperjs/core": "^2.11.8",
"@prismicio/client": "^7.8.0",
"@prismicio/next": "^1.3.6",
"@prismicio/react": "^2.7.3",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,6 @@ export const getServerSideProps: GetServerSideProps<

const client = createClient(context);

// TODO: get exhibitionHighlightTourQuery from localStorage if possible

const exhibitionHighlightTourQuery = await fetchExhibitionHighlightTour(
client,
id
Expand Down
2 changes: 1 addition & 1 deletion playwright/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"@types/node": "^22.2.0",
"axios": "^0.27.2",
"chalk": "^4.1.2",
"cli-table3": "^0.6.2",
"cli-table3": "^0.6.5",
"commander": "^9.3.0",
"log-update": "4",
"p-limit": "3.1.0",
Expand Down
2 changes: 1 addition & 1 deletion playwright/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ cli-cursor@^3.1.0:
dependencies:
restore-cursor "^3.1.0"

cli-table3@^0.6.2:
cli-table3@^0.6.5:
version "0.6.5"
resolved "https://registry.yarnpkg.com/cli-table3/-/cli-table3-0.6.5.tgz#013b91351762739c16a9567c21a04632e449bf2f"
integrity sha512-+W/5efTR7y5HRD7gACw9yQjqMVvEMLBHmboM/kPWam+H+Hmyrgjh6YncVKK122YZkXrLudzTuAukUw9FnMf7IQ==
Expand Down
5 changes: 4 additions & 1 deletion updown/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
{
"extends": "@tsconfig/node20/tsconfig.json"
"extends": "@tsconfig/node20/tsconfig.json",
"compilerOptions": {
"noEmit": true,
}
}
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3079,7 +3079,7 @@
resolved "https://registry.yarnpkg.com/@polka/url/-/url-1.0.0-next.25.tgz#f077fdc0b5d0078d30893396ff4827a13f99e817"
integrity sha512-j7P6Rgr3mmtdkeDGTe0E/aYyWEWVtc5yFXtHCRHs28/jptDEWfaVOc5T7cblqy1XKPPfCxJc/8DwQ5YgLOZOVQ==

"@popperjs/core@^2.11.7":
"@popperjs/core@^2.11.8":
version "2.11.8"
resolved "https://registry.yarnpkg.com/@popperjs/core/-/core-2.11.8.tgz#6b79032e760a0899cd4204710beede972a3a185f"
integrity sha512-P1st0aksCrn9sGZhp8GMYwBnQsbvAWsZAX44oXNNvLHGqAOcoVxmjZiohstwQ7SqKnbR47akdNi+uleWD8+g6A==
Expand Down

0 comments on commit 2baa8ca

Please sign in to comment.