feature: WEOS-1384 As a developer I should be able to specify a Go template I want to use to render a response #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # api.yaml
…mplate I want to use to render a response -Added fixtures for test -Added tests for functionailty
…WEOS-1384 # Conflicts: # api.yaml
# Conflicts: # controllers/rest/fixtures/blog.yaml
…mplate I want to use to render a response -Added template extension -Added functionality for rendering template in default response middleware
…mplate I want to use to render a response -Updated the html files -Added checks for parameter and pull them out of the context so that it can be used -Updated test
feature: WEOS-1384 As a developer I should be able to specify a Go template I want to use to render a response
…mplate I want to use to render a response -Added more test
…mplate I want to use to render a response -Added more test -Updated feature file -Debug e2e test
…mplate I want to use to render a response -Ensure test passes
…mplate I want to use to render a response -Ensure test passes
…mplate I want to use to render a response -Added helper function to add context values into a map and return -Updated default middleware for template to use this function -Added more test to increase coverage
…mplate I want to use to render a response -Fix the utils function that returns the context values to use reflect package -Added more test to cover the controller functionality -Added another endpoint for bad requests
feature: WEOS-1384 As a developer I should be able to specify a Go template I want to use to render a response
# Conflicts: # controllers/rest/utils_test.go
…WEOS-1384 # Conflicts: # controllers/rest/utils.go # end2end_test.go
akeemphilbert
requested changes
Mar 23, 2022
…mplate I want to use to render a response -Removed extra controller folder
Aidan-E
approved these changes
Mar 23, 2022
akeemphilbert
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
-Go template can now be rendered and returned
-Any data the template needs should be added to the context
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: