added note for invalid arg in delete
#397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Oct 17, 2016
| @@ -4152,6 +4152,9 @@ <h4 id="should-response-to-request-be-blocked-due-to-nosniff?"><dfn title="shoul | |||
| "<code title>request-no-cors</code>" and <var>name</var>/`<code title>invalid</code>` is | |||
| not a <span>CORS-safelisted request-header</span>, return. | |||
|
|
|||
| <p class=note>The reason for <var>name</var>/`<code title>invalid</code>` is because | |||
| "<code title>delete</code>" is not passed a value argument. | |||
There was a problem hiding this comment.
Thank you!
"delete" should be <code title=dom-Headers-delete>delete()</code> instead.
And I would suggest rewording it to say "<code title>invalid</code> is used because ..."
|
Also, I believe this is your first contribution, so your name doesn't appear in the acknowledgments section yet. Please add it there (not required). |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added note to clarify as discussed in #372