Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How should document.open handle the beforeunload handler tearing down the world? #3306

Closed
bzbarsky opened this issue Dec 20, 2017 · 0 comments
Closed

How should document.open handle the beforeunload handler tearing down the world? #3306

bzbarsky opened this issue Dec 20, 2017 · 0 comments
Labels
interop Implementations are not interoperable with each other needs tests Moving the issue forward requires someone to write tests topic: document.open()

Comments

@bzbarsky
Copy link
Contributor

https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#document-open-steps step 2 checks for the document being an active document. Then step 10 runs arbitrary script, after which the document might not be active, the browsing context may not exist, etc. What should happen in this situation? Should the passed-in string still be parsed?

In Gecko I'm likely to add another active document check after step 10 and return document immediately if that fails, without doing any parsing.
@annevk annevk added interop Implementations are not interoperable with each other needs tests Moving the issue forward requires someone to write tests labels Dec 20, 2017
@TimothyGu TimothyGu mentioned this issue Jul 12, 2018
Closed
19 tasks
TimothyGu added a commit to TimothyGu/html that referenced this issue Aug 14, 2018
@TimothyGu @annevk
Remove document.open() realm creation
7234c89 
Based on the work by Anne van Kesteren in whatwg#3651, but without the parts
concerning the session history. Changes to that area will come later
(see whatwg#3818).

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10789
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes whatwg#1698.
Fixes whatwg#3286.
Fixes whatwg#3306.
Closes whatwg#3665.

Co-authored-by: Anne van Kesteren <[email protected]>
TimothyGu added a commit to TimothyGu/html that referenced this issue Aug 14, 2018
@TimothyGu @annevk
Remove document.open() realm creation
091ac08 
Based on the work by Anne van Kesteren in whatwg#3651, but without the parts
concerning the session history. Changes to that area will come later
(see whatwg#3818).

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes whatwg#1698.
Fixes whatwg#3286.
Fixes whatwg#3306.
Closes whatwg#3665.

Co-authored-by: Anne van Kesteren <[email protected]>
@TimothyGu TimothyGu mentioned this issue Aug 14, 2018
Merged
domenic pushed a commit that referenced this issue Aug 16, 2018
@TimothyGu @domenic
document.open() simplifications, part 1
6f769b8 
In particular, removes the realm creation, document unloading, and tasks
removal steps.

Based on the work by Anne van Kesteren in #3651, but without the parts
concerning the session history. Changes to that area will come later
(see #3818).

These changes allow us to remove several auxiliary concepts that only
existed to support document.open():

- The recycle parameter to the "unload a Document" algorithm
- The window parameter to the "set the active document" algorithm

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes #1698.
Fixes #3286.
Fixes #3306.
Closes #3665.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@TimothyGu @mustaqahmed
document.open() simplifications, part 1
d13d93e 
In particular, removes the realm creation, document unloading, and tasks
removal steps.

Based on the work by Anne van Kesteren in whatwg#3651, but without the parts
concerning the session history. Changes to that area will come later
(see whatwg#3818).

These changes allow us to remove several auxiliary concepts that only
existed to support document.open():

- The recycle parameter to the "unload a Document" algorithm
- The window parameter to the "set the active document" algorithm

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes whatwg#1698.
Fixes whatwg#3286.
Fixes whatwg#3306.
Closes whatwg#3665.
mustaqahmed pushed a commit to mustaqahmed/html that referenced this issue Feb 15, 2019
@TimothyGu @mustaqahmed
document.open() simplifications, part 1
29c6fee 
In particular, removes the realm creation, document unloading, and tasks
removal steps.

Based on the work by Anne van Kesteren in whatwg#3651, but without the parts
concerning the session history. Changes to that area will come later
(see whatwg#3818).

These changes allow us to remove several auxiliary concepts that only
existed to support document.open():

- The recycle parameter to the "unload a Document" algorithm
- The window parameter to the "set the active document" algorithm

Tests: web-platform-tests/wpt#10773
Tests: web-platform-tests/wpt#10778
Tests: web-platform-tests/wpt#10815
Tests: web-platform-tests/wpt#10818

Fixes whatwg#1698.
Fixes whatwg#3286.
Fixes whatwg#3306.
Closes whatwg#3665.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interop Implementations are not interoperable with each other needs tests Moving the issue forward requires someone to write tests topic: document.open()
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bzbarsky @TimothyGu @annevk