HTML: document.open() and the beforeunload event #10778
Conversation
|
I wasn't quite sure if you could automate this. Suggestions welcome. It seems that Edge and Firefox do fire the If we could remove
that would be quite nice. |
TimothyGu
force-pushed
the
annevk/document-open-steps-beforeunload
branch
from
22e61d3
to
db2ff6b
Compare
wpt-pr-bot
requested review from
domenic,
foolip,
sideshowbarker and
zcorpan
and removed request for
ayg
| @@ -0,0 +1,12 @@ | |||
| async_test(t => { | |||
| const frame = document.body.appendChild(document.createElement("iframe")); | |||
| t.add_cleanup(() => frame.remove()); | |||
There was a problem hiding this comment.
This doesn't help much when there's a single test, and leaving it in might make debugging easier.
There was a problem hiding this comment.
We don't want the test to time out, and having frame.remove() here is the easiest way to ensure that the load event is fired on the top-level Window no matter the outcome of the test.
There was a problem hiding this comment.
Ah, I assumed it was copypasta from something with multiple tests. Never mind me.
| frame.contentWindow.onbeforeunload = t.unreached_func("beforeunload should not be fired"); | ||
| frame.contentDocument.open(); | ||
| t.step_timeout(t.step_func_done(() => { | ||
| frame.contentDocument.close(); |
There was a problem hiding this comment.
Can you add a comment describing why it's helpful to invoke document.close() here? I don't quite see why that would fire the beforeunload event, which is the only thing that would change the outcome of the test...
There was a problem hiding this comment.
Sure. The intent here is to test that open() does not fire the beforeunload event. The close() here is merely to fire the load event on the document and unblock testharness from thinking that the page has not yet loaded.
There was a problem hiding this comment.
Added a comment. LMK if that works.
Based on the work by Anne van Kesteren in whatwg#3651, but without the parts concerning the session history. Changes to that area will come later (see whatwg#3818). Tests: web-platform-tests/wpt#10773 Tests: web-platform-tests/wpt#10778 Tests: web-platform-tests/wpt#10789 Tests: web-platform-tests/wpt#10815 Tests: web-platform-tests/wpt#10818 Fixes whatwg#1698. Fixes whatwg#3286. Fixes whatwg#3306. Closes whatwg#3665. Co-authored-by: Anne van Kesteren <[email protected]>
Based on the work by Anne van Kesteren in whatwg#3651, but without the parts concerning the session history. Changes to that area will come later (see whatwg#3818). Tests: web-platform-tests/wpt#10773 Tests: web-platform-tests/wpt#10778 Tests: web-platform-tests/wpt#10815 Tests: web-platform-tests/wpt#10818 Fixes whatwg#1698. Fixes whatwg#3286. Fixes whatwg#3306. Closes whatwg#3665. Co-authored-by: Anne van Kesteren <[email protected]>
TimothyGu
force-pushed
the
annevk/document-open-steps-beforeunload
branch
from
db2ff6b
to
7d4d95f
Compare
In particular, removes the realm creation, document unloading, and tasks removal steps. Based on the work by Anne van Kesteren in #3651, but without the parts concerning the session history. Changes to that area will come later (see #3818). These changes allow us to remove several auxiliary concepts that only existed to support document.open(): - The recycle parameter to the "unload a Document" algorithm - The window parameter to the "set the active document" algorithm Tests: web-platform-tests/wpt#10773 Tests: web-platform-tests/wpt#10778 Tests: web-platform-tests/wpt#10815 Tests: web-platform-tests/wpt#10818 Fixes #1698. Fixes #3286. Fixes #3306. Closes #3665.
| @@ -0,0 +1,12 @@ | |||
| async_test(t => { | |||
| const frame = document.body.appendChild(document.createElement("iframe")); | |||
| t.add_cleanup(() => frame.remove()); | |||
There was a problem hiding this comment.
Ah, I assumed it was copypasta from something with multiple tests. Never mind me.
In particular, removes the realm creation, document unloading, and tasks removal steps. Based on the work by Anne van Kesteren in whatwg#3651, but without the parts concerning the session history. Changes to that area will come later (see whatwg#3818). These changes allow us to remove several auxiliary concepts that only existed to support document.open(): - The recycle parameter to the "unload a Document" algorithm - The window parameter to the "set the active document" algorithm Tests: web-platform-tests/wpt#10773 Tests: web-platform-tests/wpt#10778 Tests: web-platform-tests/wpt#10815 Tests: web-platform-tests/wpt#10818 Fixes whatwg#1698. Fixes whatwg#3286. Fixes whatwg#3306. Closes whatwg#3665.
In particular, removes the realm creation, document unloading, and tasks removal steps. Based on the work by Anne van Kesteren in whatwg#3651, but without the parts concerning the session history. Changes to that area will come later (see whatwg#3818). These changes allow us to remove several auxiliary concepts that only existed to support document.open(): - The recycle parameter to the "unload a Document" algorithm - The window parameter to the "set the active document" algorithm Tests: web-platform-tests/wpt#10773 Tests: web-platform-tests/wpt#10778 Tests: web-platform-tests/wpt#10815 Tests: web-platform-tests/wpt#10818 Fixes whatwg#1698. Fixes whatwg#3286. Fixes whatwg#3306. Closes whatwg#3665.
For whatwg/html#3918.