-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difference between auto popover list and filtered top layer? #8941
Comments
I suppose that having both makes it easier to work with. I can't think of any difference. Using the top layer list instead shouldn't be observable, so I'm not motivated to change chromium's implementation or make a spec PR myself. |
@josepharhar There is a slight behavior difference in the hide popover algorithm, the popover is getting removed from the auto popover list before the Not sure if that's intentional or an oversight |
Indeed. If the intent is that the difference is not observable we should either make modify both at the same time or define the auto popovers as a filter on top of the top layer. |
This isn't, strictly speaking, observable though, right? There's no way to observe the top layer ordering from JS. If you can think of a way to observe the timing of removal from top layer and removal from the popover list, I'd be inclined to call that a bug and we should think about it. If this isn't an observable change, then for two reasons, I'd lobby for keeping the existing separate popover list:
As @josepharhar mentioned though, since this isn't observable, I think we're ok changing the spec if it's something you feel strongly about. So long as the change doesn't change behavior and doesn't get in the way of the above items, ok. |
Ah right, I just remembered the @annevk mentioned maybe we could just define Anyway, I don't feel too strongly about this, I mostly filed this issue to see if there were some subtle differences that I missed, but it doesn't sound like it. |
Ahh, I think defining it this way alleviates my main concerns also, which were about clarity. So I’m ok with doing this or not - up to you. |
@mfreed7 I think the point is that the current text is not clear as the mutations happen in different locations which leads one to think that's intentional. |
Are only elements whose |
This solves an issue with elements being unconditionally added to this list and makes it clearer that the steps between it being added here and the top layer didn't mean anything. This also makes hide popover use check popover validity more to rely on the shared infrastructure. Fixes #8941 and fixes #8964.
This solves an issue with elements being unconditionally added to this list and makes it clearer that the steps between it being added here and the top layer didn't mean anything. This also makes hide popover use check popover validity more to rely on the shared infrastructure. Fixes #8941 and fixes #8964.
Is there a difference between the document auto popover list and a filtered top layer? Is there a reason both should exist?
@josepharhar @mfreed7
The text was updated successfully, but these errors were encountered: