Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should step 3.2 of "hide a popover" algorithm check for popover validity? #8964

Closed
nt1m opened this issue Mar 1, 2023 · 1 comment · Fixed by #8969
Closed

Should step 3.2 of "hide a popover" algorithm check for popover validity? #8964

nt1m opened this issue Mar 1, 2023 · 1 comment · Fixed by #8969
Labels
topic: popover The popover attribute and friends

Comments

@nt1m
Copy link
Member

nt1m commented Mar 1, 2023

https://html.spec.whatwg.org/#hide-popover-algorithm

It makes sense to me, for consistency with show.

cc @josepharhar @mfreed7 @domenic @annevk
@annevk annevk added the topic: popover The popover attribute and friends label Mar 1, 2023
@josepharhar
Copy link
Contributor

I don't see anything wrong with using check popover validity instead of looking at the popover stack. They should be functionally the same, but using check popover validity is more consistent and easier to understand.

annevk added a commit that referenced this issue Mar 1, 2023
@annevk
Define auto popover list in terms of the top layer
24e0bdf 
This solves an issue with elements being unconditionally added to this list and makes it clearer that the steps between it being added here and the top layer didn't mean anything.

This also makes hide popover use check popover validity more to rely on the shared infrastructure.

Fixes #8941 and fixes #8964.
@annevk annevk mentioned this issue Mar 1, 2023
Merged
@annevk annevk closed this as completed in 1257236 Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: popover The popover attribute and friends
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Define auto popover list in terms of the top layer whatwg/html
3 participants
@annevk @nt1m @josepharhar