forked from keplergl/kepler.gl
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase onto keplergl/kepler.gl #2
Open
james-willis
wants to merge
52
commits into
wherobots:master
Choose a base branch
from
keplergl:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [Fix] layer popover mapIndex Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
… dataset (#2532) - when switching from one dataset to another, we call layer.validateVisConfig to validate visConfig with new dataset Signed-off-by: Ihor Dykhta <[email protected]>
- Added a toggle to render absolute height without domain-based scaling. Signed-off-by: Ihor Dykhta <[email protected]>
* Update DEVELOPERS.md, specify v18 Node.js required Signed-off-by: Don McCurdy <[email protected]>
* Fix for custom basemap styles not loading Signed-off-by: Adam Krebs <[email protected]> * Make custom style icon use NO_BASEMAP_ICON Signed-off-by: Adam Krebs <[email protected]> --------- Signed-off-by: Adam Krebs <[email protected]>
…sh checkout (#2596) * Implements a number of fixes to get repo building on fresh checkout When trying to checkout and run Kepler a number of build issues prevent the application from starting successfully. This collection of changes ensures that the application can be cloned / installed / built without error. * Adds a @ts-ignore to resolve a build failure related to an unknown type * Running 'stab' multiple times will no longer produce a directory-already-exists error * Updating all babel configs to apply the latest transforms, based on PR feedback * Adds missing dependencies to all package.json files * Another attempt at resolving build issues * Adds missing babel transform deps to package.jsons * Resolves dep version mismatches contributing to build failures * Adds ts-ignore statements to workaround TS failures after making these changes * Few small fixes that were uncovered in PR * Reverts dev/null redirect for stab command Signed-off-by: Alex Bain <[email protected]> --------- Signed-off-by: Alex Bain <[email protected]> Co-authored-by: Shan He <[email protected]>
- Fix jest test by importing loader.gl/polyfill from esm - Fix browser jsdom test by importing loaders.gl/polyfill from esm - Import @kepler.gl src in test - Delete unused files - Update jsdom Signed-off-by: Shan He <[email protected]>
…e errors (#2607) - Run lint with autofix - Run prettier with autofix - Added @typescript-eslint - Remaining Todos: need to fix types and turn on @typescript-eslint/no-explicit-any --------- Signed-off-by: Shan He <[email protected]>
- generate tape test cover report with yarn cover-tape - generate jest test cover report with yarn cover-jest - merge json report with istanbul-merge - generate final report with nyc - coverall report back to 71% - Fix cover and netlify badge in readme --------- Signed-off-by: Shan He <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
…2587) Signed-off-by: dependabot[bot] <[email protected]>
furqaankhan
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @daicjohn thoughts?
- Upgrade default yarn version to Yarn 4.4.0 https://yarnpkg.com/blog/release/4.0 - Add .yarnrc.yml - Add volta - Add packageManager to package.json - Fix github workflows - Fix netlify build and deploy - Future work might needed to fix npm publish workflow To Update your local master: run yarn cache clean and yarn install and yarn bootstrap for a fresh install --------- Signed-off-by: Shan He <[email protected]>
) - Use esbuild in demo-app - Remove d3-request, start using fetch - Upgrade react-markdown, react-virtualized because they use methods that only runs in node Later ToDos: Migrate from webpack to esbuild to build kepler.gl website --------- Signed-off-by: Shan He <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
- The "assert" was removed in NodeJS 22. Instead "with" should be used. This was added in v17.1.0, v16.14.0. Signed-off-by: Sergey Markov <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]> Co-authored-by: Ilya Boyandin <[email protected]>
) Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]>
Signed-off-by: Ihor Dykhta <[email protected]> Co-authored-by: Ilya Boyandin <[email protected]>
* update loaders to 4.1.1
* Fixed disapiaring animation time control Signed-off-by: Sergey Markov <[email protected]>
- Layer Column Mode - add ColumnMode support for TripLayer - Choose between geoJson and CSV columns for trip layer - create new component for column mode config - calculate animation config when update layer column - Fill all columns from column mode when initializing it from prop - Auto detect lat, lng, altitude field pairs - Auto create trip layer if a dataset contain field pairs, timestamp, and `id` | `uuid` fie - Add column config component test Signed-off-by: Ihor Dykhta <[email protected]>
- This PR splits out a more general-purpose ColumnModeConfig that we can use separately outside of the layer panel. - Looks the same as before, changes here should not affect user experience Signed-off-by: Ihor Dykhta <[email protected]>
…2664) - Support `columnMode: table` in Polygon layer - Improve layer column auto-assign logic - Add modal info for trip and geojson layer Signed-off-by: Ihor Dykhta <[email protected]>
…2665) - Cleanup columnMode logic, remove use of `assignColumnsByColumnMode` - Add neighbor column mode to arc layer - Support arc from hex_id - [fix] Ensure Polygon layer filtering in table columns mode works - [fix] Timestamp in the Trips layer is not required after switching from Polygon Signed-off-by: Ihor Dykhta <[email protected]>
* add point column mode in point layer * update point layer geojson column mode; update test cases; Signed-off-by: Ihor Dykhta <[email protected]>
* [unfork] Adding application config (proposal for discussion) (#862) * Application config * Update kepler-gl.tsx * Trying to fix failing tests * Move applicationConfig to separate file to avoid test errors * Revert "Trying to fix failing tests" This reverts commit 1ee283aaa9b24fe968928ceb673402c35a022a71. * Moving export to the end * Adding missing dependency * Comment and more explicit export * Try to fix import errors * Remove unnecessary change * Moved applicationConfig to utils in another attempt to avoid errors in CI * Reorg * update demo-app yarn.ock Signed-off-by: Shan He <[email protected]> --------- Signed-off-by: Shan He <[email protected]> Co-authored-by: Ilya Boyandin <[email protected]>
…switching dataset (#2676) * [Enhancement] call layer methods to validate visconfig when switching dataset --------- Signed-off-by: Shan He <[email protected]> Co-authored-by: Ilya Boyandin <[email protected]>
* Show radius legend in point layer Co-authored-by: Ilya Boyandin <[email protected]>
* Update deps in html export Signed-off-by: Ilya Boyandin <[email protected]> * Adding yarn version to package.json Signed-off-by: Ilya Boyandin <[email protected]> --------- Signed-off-by: Ilya Boyandin <[email protected]>
…onal components (#2679) Use of defaultProps and findDomNode has been deprecated. This change tries to remove use of both, to avoid React warnings in the dev console. - Remove defaultProps in functional components, some class components are still using defaultProps - Add default props to functional components method to be used - Fix replace-component example - Remove use of react-clickoutside (which uses findDomNode) There are still warnings about deprecated APIs from the following dependencies, further dependency upgrade is needed - react-modal uses findDomNode - react-markdown uses defaultProps - react-router: uses childContextTypes
* Support dynamic map lib using the application config --------- Signed-off-by: Shan He <[email protected]> Co-authored-by: Ilya Boyandin <[email protected]>
- Added billboard toggle for point and icon layers - Added billboard and fadeTrail toggles for trips layer Signed-off-by: Ihor Dykhta <[email protected]> Co-authored-by: Igor Dykhta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm wondering if the change to the reactIntl here: bindings/kepler.gl-jupyter/js/webpack/build-html.js
Will resolve this bug: https://www.notion.so/wherobots/Exported-Kepler-Visualizations-Crash-when-Pulling-Out-Menu-c472ef79e4d64faab4f9e7c90a97ef2a?pvs=6&utm_content=c472ef79-e4d6-4faa-b4f9-e7c90a97ef2a&utm_campaign=T046Z383PCL&n=slack&n=slack_link_unfurl