Fix the bootstrap Python code to call the customized run() instead of the original bootstrap.run() #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the original bootstrap.run()
whitphx
force-pushed
the
perf/replace-bootstrap-run
branch
from
6d4b09a
to
4d75452
Compare
whitphx
added a commit
that referenced
this pull request
Aug 31, 2022
whitphx
added a commit
that referenced
this pull request
Aug 31, 2022
whitphx
added a commit
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #121With the performance inspection in #121, we found this does not affect so much for the performance.
This can be beneficial in that it suppress some warnings that are unavoidable on stlite environment due to network connectivity and it also avoids unnecessary prints which are done with
_print_url()in the original function.