New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set browser.serverAddress config #185

Closed

whitphx wants to merge 1 commit into main from fix/set-browser-server-address-config

Owner

whitphx commented Aug 31, 2022

No description provided.


          Set browser.serverAddress config

b1d26e0

Owner Author

whitphx commented Aug 31, 2022

Withdraw this PR because

browser.serverAddress should be kept null according to its meaning described in the following code
https://github.com/streamlit/streamlit/blob/1.12.2/lib/streamlit/config.py#L667-L679
This change suppresses the undesirable prints at the boot (e.g. _print_url() called from bootstrap.run()), but this can also be achieved with Fix the bootstrap Python code to call the customized run() instead of the original bootstrap.run() #181

whitphx closed this

whitphx deleted the fix/set-browser-server-address-config branch

August 31, 2022 03:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet