Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject Tracking Workflow #204

Merged
merged 11 commits into from
Aug 29, 2024
Merged

Subject Tracking Workflow #204

merged 11 commits into from
Aug 29, 2024

Conversation

Yun-Wu
Copy link
Contributor

@Yun-Wu Yun-Wu commented Aug 23, 2024

  • add subject tracking spec
  • generated
  • trajectory map
  • Add mean speed single value
  • max speed
  • Add time density map
  • generated files
  • dashboard

@cisaacstern
Copy link
Collaborator

Really happy to see that merging #179 resulted in zero conflicts 🎉

Following the changes from #205, merging main in this PR should resolving numpy version related testing failures

@Yun-Wu
Copy link
Contributor Author

Yun-Wu commented Aug 27, 2024

Thank you @cisaacstern for fixing the test! The pr is ready for review now!

Copy link
Collaborator

@cisaacstern cisaacstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yun-Wu looks great TYSM!

I realized that we were missing a test for the async compilation so I've made a PR to this PR with that fix: #213. Assuming tests pass there, can we merge that here before this goes in?

Note, however, that the e2e tests for the subject tracking workflow did run (and pass) already in your PR:

https://github.com/wildlife-dynamics/ecoscope-workflows/actions/runs/10577546386/job/29305723006?pr=204#step:7:208

My PR just adds a check for adding the compiled artifact to the repo.

@Yun-Wu Yun-Wu merged commit 170d841 into main Aug 29, 2024
5 checks passed
@Yun-Wu Yun-Wu deleted the subject branch August 29, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task: Support Day/Night Ratio Implement Subject Tracking Workflow with existing features
2 participants