Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micromamba for ci #205

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Micromamba for ci #205

merged 4 commits into from
Aug 26, 2024

Conversation

cisaacstern
Copy link
Collaborator

@cisaacstern cisaacstern commented Aug 23, 2024

closes #206

@cisaacstern
Copy link
Collaborator Author

Thanks @Yun-Wu for your feedback in #179 (comment), which is relevant here too, is this is the same implementation.

I have starting thinking through some alternate pathways in #207, but those will require more thought, so if its helpful to just use this PR's diff to unblock other work for now, please feel free to merge this (or not, if you are not blocked).

Comment on lines +15 to +19
environment-name: [
"py3.10-ecoscope1.8.2",
"py3.11-ecoscope1.8.2",
"py3.12-ecoscope1.8.2",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to attach ecoscope version here? It means every time we upgrade ecoscope we need to change the github action too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synced offline and will resolve it later.

@cisaacstern cisaacstern merged commit 522ee97 into main Aug 26, 2024
5 checks passed
@cisaacstern cisaacstern deleted the micromamba-for-ci branch August 26, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests are broken due to ecoscope core incompatibility with numpy>=2
2 participants