Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'showLevel' option disregarded (Console transport tested) #557

Closed
VipSaran opened this issue Feb 22, 2015 · 2 comments
Closed

'showLevel' option disregarded (Console transport tested) #557

VipSaran opened this issue Feb 22, 2015 · 2 comments

Comments

@VipSaran
Copy link
Contributor

Test case:

var logger = require('winston');
logger.remove(logger.transports.Console);
logger.add(logger.transports.Console, {'showLevel': false});

logger.info('some info');
logger.error('some error');

Output:

$ node test-winston.js
info: some info
error: some error

Expected result would be:

$ node test-winston.js
some info
some error

Winston version: 0.9.0,
Node.js version: 0.10.18.

@indexzero
Copy link
Member

We should have better test coverage here obviously. Could you perhaps add one? 😄

@VipSaran
Copy link
Contributor Author

Test coverage was adequate, but the problem was that test was passing but the code didn't work.
I've created a pull request for this.

indexzero added a commit that referenced this issue Mar 8, 2015
fix for 'showLevel' value not being used in Console transport (#557) and description of debugStdout usage for Console Transport (#556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants