Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for 'showLevel' value not being used in Console transport (#557) and description of debugStdout usage for Console Transport (#556) #558

Merged
merged 2 commits into from
Mar 8, 2015

Conversation

VipSaran
Copy link
Contributor

Although test cases cover the scenario and the tests pass:

$ npm test test/transports/console-test.js

> [email protected] test e:\Work\workspace_private\winston
> vows --spec test/transports/console-test.js


  ♢ winston/transports/console

  An instance of the Console Transport with showLevel on
    ✓ should have level prepended
  An instance of the Console Transport with showLevel off
    ✓ should not have level prepended

the open issue shows that this scenario fails in a "real world" test. Hence this fix.

@VipSaran VipSaran changed the title fix for 'showLevel' value not being used in Console transport (#557) fix for 'showLevel' value not being used in Console transport (#557) and description of debugStdout usage for Console Transport (#556) Feb 24, 2015
@indexzero
Copy link
Member

Awesome! Thanks @VipSaran

indexzero added a commit that referenced this pull request Mar 8, 2015
fix for 'showLevel' value not being used in Console transport (#557) and description of debugStdout usage for Console Transport (#556)
@indexzero indexzero merged commit ffaf3ec into winstonjs:master Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants