Fix 'Maximum call stack size exceeded' error with custom formatter #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veger
force-pushed
the
fix_max_call_size_error
branch
from
fdb0561
to
4ce8b16
Compare
|
@indexzero Could you merge and publish the fix pls? |
|
Hey @indexzero |
|
I agree, we need this fix shortly. Please, consider to review and merge this PR as quickly as possible. @indexzero |
|
Please have this merged asap! |
|
Please merge - fixes my bug with circular objects |
|
Merge please, or add some users to the project who are active with the pull requests. 28 PR's? C'mon now... There are a number of these call stack exceeded/infinite loop issues with unsafe cloners and lack of cycle checking in these recursive fn's. |
veger
force-pushed
the
fix_max_call_size_error
branch
from
4ce8b16
to
01cf7ce
Compare
|
Yes. Been waiting a long time for this. Please merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #862
As @thinkkevin explains: "Need to have
options.metadecycled beforeclone".