always decycle objects before cloning

[jifeon]

I guess it fixes #862, #474 and #914

[ngocketit]

When is it gonna be merged?

[jifeon]

@ngocketit previous PR about this problem hadn't been being merged for 9 months. You can use @jifeon/winston#2.3.1, it contains only this commit on the top of winston#2.3.1

[ngocketit]

Thank you @jifeon! However, I couldn't seem to find the repos you mentioned. Could you please help?

[jifeon]

@ngocketit Repo is my fork: https://github.com/plyo/winston
It's published using npm namespace https://www.npmjs.com/package/@jifeon/winston
You can install it with

$ npm i --save @jifeon/winston

and use it like this:

import winston from '@jifeon/winston'

until this PR is merged. Then you can switch back to origin package.

[ngocketit]

I got error @jifeon/winston' is not in the npm registry but I could install it from your git repos. Thank you!

[jeesus]

Any updates?

[vbardales]

👍

[indexzero]

Thank you for your contribution. Will try to get this out soon.

[jifeon]

Will try to get this out soon.

So cool, it would be nice if you post npm version with the fix here

[david-unergie]

Hi,

as we discussed with @crabicode, this pull request seems to bring a regression about Error object.
Meta is {} when error is passed to the formatter func.

winston = require('winston')
logger = new (winston.Logger)({
    transports: [
        new (winston.transports.Console)({
            json: false,
            formatter: (...argv) => {
                console.log(argv);
                return 'baz';
            },
        }),
    ]
})

logger.info('foo', new Error('bar'))

I got on the console:

[ { colorize: false,
    json: false,
    level: 'info',
    message: 'foo',
    meta: {},
    stringify: undefined,
    timestamp: false,
    showLevel: true,
    prettyPrint: false,
    raw: false,
    label: null,
    logstash: false,
    depth: null,
    formatter: [Function: formatter],
    align: false,
    humanReadableUnhandledException: false } ]
baz

[igrek8]

@indexzero, can we decide on further actions on merges, which brought that unwanted behaviour?

[netpoetica]

I'm trying to determine if this, or an alternative fix, ever got merged in and at which version?