Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide a way to configure SFT service discovery #322

Merged
merged 2 commits into from
Aug 27, 2020
Merged

Provide a way to configure SFT service discovery #322

merged 2 commits into from
Aug 27, 2020

Conversation

akshaymankar
Copy link
Member

flokli
flokli reviewed Jul 31, 2020
View reviewed changes
charts/brig/templates/configmap.yaml Outdated
sftSRVServiceName: {{ .sftSRVServiceName }}
{{- end }}
{{- if .sftDiscoveryIntervalSeconds }}
sftSRVServiceName: {{ .sftDiscoveryIntervalSeconds }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate key.

Also, I wonder why we assemble sftBaseDomain and sftSRVServiceName in the backend, and not just pass the fully qualified record name to the server.

fisx
fisx approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is odd, but maybe there is a good reason for that. Anyway looks sound to me.

@akshaymankar
Copy link
Member Author

Indentation is odd, but maybe there is a good reason for that. Anyway looks sound to me.

The reason is that we are templating to output some indentation sensitive code (YAML) 😢

@akshaymankar akshaymankar merged commit 461e077 into develop Aug 27, 2020
@akshaymankar akshaymankar deleted the akshaymankar/sft-discovery-1 branch August 27, 2020 08:20
@tiago-loureiro tiago-loureiro mentioned this pull request Sep 4, 2020
Closed
@akshaymankar akshaymankar mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisx fisx fisx approved these changes

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshaymankar @flokli @fisx