Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release_2020_09_04 #336

Closed
wants to merge 19 commits into from
Closed

Release_2020_09_04 #336

wants to merge 19 commits into from

Conversation

tiago-loureiro
Copy link
Contributor

2020-09-04

Features

Bug Fixes

Internal Changes

akshaymankar and others added 19 commits July 31, 2020 10:08
This reverts commit e719c3e.

This was a mistake.
(Commit 1) [tf-module] Introduce network load balancer

This module is meant, but not necessarily bound, to facilitate ingress
for kubernetes nodes on AWS. It is assumed that TLS termination will
happen on the cluster, hence the choice of using a network LB.

* Integrate review feedback

(Commit 2) [tf-module:nlb] Introduce inputs for subnet & instance IDs; duplicated resources

* to allow a explicit dependency, instead of obtaining instances and subnet IDs
  via data resources, this introduces inputs to provide both
* remove port-mapping in favour of additional but very similar resources to increase
  readability

(Commit 3) [tf-module:nlb] Adjust README to be consistent with the latest changes of the module interface

* move from instance role to list of IPs
* add example for data sources
* fix phrasing

Co-authored-by: Julia Longtin <[email protected]>
For consistency between different services as well as demo-values and prod-values
This makes it more obvious that this value might need to be modified if the default is not desired.

* add cargohold AWS region to prod-values.example.yaml

* demo-values.example.yaml: Add default region here, too
* Add logrotation of 3 days to all pod logs

* improve logrotate arguments to actually do what we want; add comments

* move to its own playbook
…331)

[tf-module:cargohold] Replace subnet IDs input with route table IDs

This removes the 'implicit' data dependency that can cause a race condition
between subnets and route tables. It makes it more clear what the module depends
on and should make it more easy to `depends_on` in the future (TF v0.13).

Co-authored-by: Julia Longtin <[email protected]>

* shuffle things around so that the aws-cargohold-asset-storage module handles its own security group.
pass in a vpc id, instead of relying on a data statement, and current…
@jschaul
Copy link
Member

jschaul commented Oct 22, 2020

Obsolete. There have been fresh releases since.

@jschaul jschaul closed this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants