Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use network-2.7 for more informative "connection failed" errors #586

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Use network-2.7 for more informative "connection failed" errors #586

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d234f9d
Use network-2.7
Jan 23, 2019
27dd503
Fix compilation, better comments
Jan 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions stack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,8 @@ extra-deps:
- network-uri-static-0.1.1.0
- list-t-1.0.1 # 1.0.0.1 doesn't build
- unliftio-0.2.10 # for pooled concurrency utils in UnliftIO.Async
- network-2.7.0.2 # to get nicer errors when connections fail
- HaskellNet-SSL-0.3.4.1 # first version to support network-2.7

# the following are just not on Stackage (and most of these were present in
# LTS-11 but got evicted in LTS-12)
Expand Down
2 changes: 2 additions & 0 deletions tools/bonanza/src/Bonanza/Metrics.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{-# LANGUAGE OverloadedStrings #-}
{-# LANGUAGE RecordWildCards #-}

{-# OPTIONS_GHC -Wno-deprecations #-} -- for Network.BSD

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't you resolve the deprecations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Network.BSD was moved to network-bsd, which is not deprecated but is network >= 3.0 only. The ecosystem hasn't moved to network-3.0 yet so we can't use it. Tracking issue: commercialhaskell/stackage#4312

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that those deprecations are kinda "we're going to move it out", not "don't use it because better options are available".

module Bonanza.Metrics
( Stats (..)
, debugCollectd
Expand Down