Use network-2.7 for more informative "connection failed" errors #586
Conversation
|
Warning: ~100 packages will be rebuilt after this is merged. |
|
Perhaps it's better to leave it until the evening so that alpine-builder can be rebuilt promptly. |
| @@ -1,6 +1,8 @@ | |||
| {-# LANGUAGE OverloadedStrings #-} | |||
| {-# LANGUAGE RecordWildCards #-} | |||
|
|
|||
| {-# OPTIONS_GHC -Wno-deprecations #-} -- for Network.BSD | |||
|
|
|||
There was a problem hiding this comment.
Couldn't you resolve the deprecations?
There was a problem hiding this comment.
No. Network.BSD was moved to network-bsd, which is not deprecated but is network >= 3.0 only. The ecosystem hasn't moved to network-3.0 yet so we can't use it. Tracking issue: commercialhaskell/stackage#4312
There was a problem hiding this comment.
My understanding is that those deprecations are kinda "we're going to move it out", not "don't use it because better options are available".
|
Tests are passing now. |
|
By golly! Not 1️⃣ but 2️⃣ green circles. Then I will merge this one in the evening today and rebuild alpine-builder. |
Starting from network-2.7,
getAddrInfoalso prints the host that it was trying to connect to.