Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for disallowing certain phone number prefixes #593

Merged
merged 14 commits into from
Feb 1, 2019
Merged

Add support for disallowing certain phone number prefixes #593

merged 14 commits into from
Feb 1, 2019

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented Jan 23, 2019

This PR is part of a cat and mouse game.

Happy to take comments about perhaps more consistent naming (exclude, block, disallow, blacklist, ... ?).

neongreen
neongreen approved these changes Jan 24, 2019
View reviewed changes
libs/brig-types/src/Brig/Types/Common.hs Outdated Show resolved Hide resolved
libs/brig-types/src/Brig/Types/Common.hs Outdated Show resolved Hide resolved
libs/brig-types/src/Brig/Types/Common.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API/User.hs Show resolved Hide resolved
services/brig/src/Brig/Data/Blacklist.hs Outdated Show resolved Hide resolved
neongreen
neongreen reviewed Jan 24, 2019
View reviewed changes
services/brig/schema/src/V56.hs Show resolved Hide resolved
services/brig/src/Brig/API.hs Outdated Show resolved Hide resolved
fisx
fisx approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've looked at the style and it still looks fine. i've added a few remarks, most of them probably unnecessary.

services/brig/src/Brig/API.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API/User.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API/User.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/Data/Blacklist.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/API.hs Outdated Show resolved Hide resolved
@tiago-loureiro
Copy link
Contributor

Now that I review this, I noticed that we send out SMS/calls in other places, namely sendLoginCode; while it's easier to exploit during activation, one can imagine exploiting numbers that have been actually already registered. Let's tackle that on a separate PR.

tiago-loureiro
tiago-loureiro approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@tiago-loureiro tiago-loureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment to add a comment, :shipit:

@jschaul jschaul merged commit 6415516 into develop Feb 1, 2019
@jschaul jschaul deleted the feature/phone-exclusions branch February 1, 2019 15:06
This was referenced Feb 14, 2019
Closed
Closed
@neongreen neongreen mentioned this pull request Feb 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neongreen neongreen neongreen approved these changes

@fisx fisx fisx approved these changes

@tiago-loureiro tiago-loureiro tiago-loureiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jschaul @tiago-loureiro @neongreen @fisx