Release/2019-02-14 #630
Closed
Release/2019-02-14 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) * detect architecture, ensure architecture is detected before trying to create a .deb, and mark rules that do not create files as phony. * expand list of dependencies, and add debian build directions. * allow for debian packages to be built on non-amd64 architectures. * incorporate feedback in a warning that we do not need to install this at the system level. * reorder docker above generic.
* Cleanup as promised here: #592 (comment) * Swagger: update docs, remove dead code.
* Fix: toSCIMUser location, timestamp attributes. * Cleanup. * TODO: this is the wrong approach. * Refactor. * Refactor: construct optional SAML subjectID during validation. * Better validation. * Haddocks. * Resolve bogus TODO. correct me if i'm wrong, but NewUser has no Handle field, so this necessarily has to happen in two steps, no? * Fix: store scim users with all metadata in spar; sync with brig later. * ... * ... * ... * Cleanup. * Haddocks, test case skeletons. * Fix: SCIM.UserDB.get never returned Nothing. (Before this branch, it sometimes returned Nothing and something threw an exception. This is not much better. Now, all failures to find the user will yield Nothing, not an exception.) * Resolve name clashes (more heavily qualified imports). * Refactor: factor SCIM.Types out of SCIM module. * Refactor: I am going to need this function in a moment. * Cleanup. (This should really be fixed in hscim by introducing a constraint class for SCIMHandler.) * Cleanup. * Update scim user. * More scim integration tests. * Refactor: ValidSCIMUser contains a complete SAML.UserRef now. * More scim integration tests. * haddocks. * hi ci * Generalize 'userShouldMatch' * No more updateUserName and updateUserHandle * Add a TODO * Remove unhelpful comments. these comments wheren't only not adding any information to function name plus signature, they were also already out of sync with them from the start. * Follow naming conventions in cassandra. * Cleanup * Cleanup Co-Authored-By: fisx <[email protected]> * Haddocks * Cleanup Co-Authored-By: fisx <[email protected]> * Better error message. * HasCallStack * Update a TODO * ... * Comments + rename putUser_ + add a wrapper for putUser_ * Test that everything works fine when name and handle are unchanged * Use weak ETags instead of strong ETags; move stuff around * Recalculate version in updSCIMStoredUser' * Fixes after the merge * More renaming * macOS :/ * macOS 2 :/ * More renaming fixes * Fix comment * Newest hscim * Fix version-related tests * Remove outdated comment (no more 'schemas') * FUTUREWORK * Forbid emails and phone numbers * No /Meta endpoint * Fix compilation * No more 'fromJust' * Link to a Github comment * Bring the comment back * Add a comment about SCIM user creation flow * Rewrap comments * Revert "Forbid emails and phone numbers" This reverts commit 9220794. * Test phone numbers as well
* Use network-2.7 * Fix compilation, better comments
* Slightly update SCIM comments in regard to names, etc * Fixup
* Test that users who do not own the team are unable to create a token * Test that SCIM tokens do not allow editing users from other teams * Test that we reject invalid handles in scim creation * More scim tests. * Clean up test runner option leftovers
* `metrics-wai` now features its own routing tree type `Paths` and can
now be used independently of wai-route.
* support for computing `Paths` from `wai-route` as well as
`servant` routing tables.
non-existent URI paths *may* show different behavior in the
`wai-routes` case now (they may show up under their name rather than
under "N/A"), but other than that, behavior of all services but
spar does not change.
* `spar` metrics end-point moved from `/metrics` to `/i/metrics` and
distinguishes uri paths.
* Fix cabal warnings.
* Add new list of default extensions Add explicit signatures to solve Monomorphic binding problems caused by adding GADTs global extension Add code-style doc with extensions
* When creating a user in SCIM, check that the UserRef is not taken * throwScim -> throwError * Tests for duplicate external IDs
|
updated description and CHANGELOG.md hope i didn't forget anything. |
|
Should be fine. The only thing that prevents me from approving this is #604, because I don't know how metrics work and whether anything else needs to be done elsewhere when deploying this. |
|
Superseded by #634. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changes
/scim(see hscim package or the standards for the details; no swagger docs).put "/i/users/:uid/managed-by"for marking scim-managed users (no swagger docs)/i/users/phone-prefixes/(no swagger docs)Bug fixes
Internal changes