Add module descriptions for all Spar modules #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(We can check that on CI by running Haddock.) |
jschaul
approved these changes
Feb 7, 2019
fisx
reviewed
Feb 11, 2019
| @@ -6,6 +6,7 @@ | |||
| {-# LANGUAGE ScopedTypeVariables #-} | |||
| {-# LANGUAGE PolyKinds #-} | |||
|
|
|||
| -- | Swagger utilities. | |||
There was a problem hiding this comment.
I guess that means a better place for this module would be Spar.API.Swagger.Util. Oh well.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very often bitten by "should X go to this module or to some other module?", so I thought spending a bit of time on adding module descriptions would be a good idea.
I would also love it if CI barked at PRs that introduce modules without documentation. Thoughts?