Break down SCIM modules and annotate SCIM tests #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neongreen
force-pushed
the
artyom-scim-tests
branch
from
35ba5d2
to
2d29dec
Compare
neongreen
force-pushed
the
artyom-scim-tests
branch
from
2d29dec
to
84bfb69
Compare
neongreen
changed the title
|
|
Tests failed because stale files are not cleaned properly in the Ubuntu job 🔪 |
fisx
approved these changes
Feb 13, 2019
| -- Related, but not the solution: https://github.com/hspec/hspec/pull/397 | ||
| -- On the other hand, we cannot easily 'mkEnvFromOptions' inside each module, since it | ||
| -- requires @-s@, @-i@ command line modules, which will make 'hspec' choke. Related, but not | ||
| -- the solution: https://github.com/hspec/hspec/pull/397. |
| describe "Spar.Data" Test.Spar.DataSpec.spec | ||
| describe "Spar.Intra.Brig" Test.Spar.Intra.BrigSpec.spec | ||
| describe "Spar.Scim" Test.Spar.ScimSpec.spec | ||
| describe "Spar.Scim.Auth" Test.Spar.Scim.AuthSpec.spec |
There was a problem hiding this comment.
I don't like this change. Test was for the test cases, everything else for the tooling. But ok, now it's changed. I hope I won't change it back at some point. :-)
There was a problem hiding this comment.
never mind, that comment made no sense.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No new tests yet but there will be some.