Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Authorization tests to Spar regarding Scim User management #620

Merged
merged 5 commits into from
Feb 13, 2019

Conversation

ChrisPenner
Copy link
Contributor

Purpose: Ensure that user management is secure and auth is respected

(tokTeamB, _) <- registerIdPAndScimToken

-- Create and add a first user: success!
createUser_ (Just tokTeamA) user1 (env ^. teSpar)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use createUser here.

Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(if somebody else wants to review as well go ahead, but i think this is fine.)

@neongreen neongreen merged commit 3e99901 into develop Feb 13, 2019
neongreen pushed a commit that referenced this pull request Feb 13, 2019
@neongreen
Copy link
Contributor

Oops, merged and only then realized it wasn't my branch :/

@neongreen neongreen deleted the scim-tests branch February 13, 2019 18:20
@neongreen
Copy link
Contributor

I hope it's fine with this one, but if it wasn't ready then yell.

@fisx
Copy link
Contributor

fisx commented Feb 13, 2019

it was double-approved, so sure. :-)

This was referenced Feb 14, 2019
@neongreen neongreen mentioned this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants