Remove superfluous view pattern #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neongreen
approved these changes
Feb 15, 2019
fisx
reviewed
Feb 15, 2019
| unreachable :: Nexmo.CallErrorResponse -> AppT IO () | ||
| unreachable ex = warn (toException ex) >> throwM PhoneNumberUnreachable | ||
| barred :: Nexmo.CallErrorResponse -> AppT IO () | ||
| barred ex = warn (toException ex) >> throwM PhoneNumberBarred |
There was a problem hiding this comment.
i was slightly in favor of the old version, but fine. :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd missed one section where I'd agreed to remove View Patterns as requested by @jschaul.
He asked that I fix it up :)