Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous view pattern #632

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Remove superfluous view pattern #632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions services/brig/src/Brig/Phone.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,10 @@ sendCall call = unless (isTestPhone $ Nexmo.callTo call) $ do
_ -> False
]

unreachable (toException -> ex) = warn ex >> throwM PhoneNumberUnreachable
barred (toException -> ex) = warn ex >> throwM PhoneNumberBarred
unreachable :: Nexmo.CallErrorResponse -> AppT IO ()
unreachable ex = warn (toException ex) >> throwM PhoneNumberUnreachable
barred :: Nexmo.CallErrorResponse -> AppT IO ()
barred ex = warn (toException ex) >> throwM PhoneNumberBarred
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was slightly in favor of the old version, but fine. :-)


warn ex = Log.warn
$ msg (val "Voice call failed.")
Expand Down