Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and assign unit within cable length attribute #198

Merged
merged 4 commits into from
Dec 13, 2020
Merged

Detect and assign unit within cable length attribute #198

merged 4 commits into from
Dec 13, 2020

Conversation

formatc1702
Copy link
Collaborator

Built on new length_unit attribute from #196.

@formatc1702 formatc1702 changed the base branch from master to dev November 16, 2020 16:59
@formatc1702 formatc1702 added this to the v0.3 milestone Nov 16, 2020
@formatc1702 formatc1702 mentioned this pull request Nov 17, 2020
Open
kvid
kvid requested changes Nov 28, 2020
View reviewed changes
src/wireviz/DataClasses.py Outdated Show resolved Hide resolved
src/wireviz/DataClasses.py Outdated Show resolved Hide resolved
src/wireviz/DataClasses.py Show resolved Hide resolved
src/wireviz/DataClasses.py Outdated Show resolved Hide resolved
src/wireviz/DataClasses.py Outdated Show resolved Hide resolved
src/wireviz/DataClasses.py Outdated Show resolved Hide resolved
src/wireviz/DataClasses.py Outdated Show resolved Hide resolved
@formatc1702
Copy link
Collaborator Author

Thanks for the suggestions, they've all been included.

@formatc1702 formatc1702 merged commit 606ddbf into dev Dec 13, 2020
@formatc1702 formatc1702 deleted the feature/auto-length-unit branch December 13, 2020 11:39
formatc1702 added a commit that referenced this pull request Dec 13, 2020
@formatc1702
Add #198
2ea0e3f
@kvid kvid mentioned this pull request Dec 26, 2020
Closed
kvid added a commit to kvid/WireViz that referenced this pull request Dec 26, 2020
@kvid
Assign the default cable length unit when not present
b294033 
Bug: Failing to assign the default cable length unit when not present.
It was introduced in wireviz#198.

Fix: Test the correct cable attribute. This fix solves issue wireviz#205.
@kvid kvid mentioned this pull request Dec 26, 2020
Merged
formatc1702 pushed a commit that referenced this pull request Dec 29, 2020
@kvid
Assign the default cable length unit when not present (#206)
da56841 
Bug: Failing to assign the default cable length unit when not present.
It was introduced in #198.

Fix: Test the correct cable attribute. This fix solves issue #205.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvid kvid kvid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@formatc1702 @kvid