Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect and assign unit within cable length attribute #198

Merged
merged 4 commits into from
Dec 13, 2020
Merged

Detect and assign unit within cable length attribute #198

merged 4 commits into from
Dec 13, 2020

Commits on Nov 16, 2020

  1. Detect and assign unit within cable length attribute

    @formatc1702
    formatc1702 committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    694f3a3 View commit details
    Browse the repository at this point in the history

  2. Include user input in unit parsing error messages

    @formatc1702
    formatc1702 committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    1d29c6c View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2020

  1. Apply suggestions from code review by @kvid 

    Co-authored-by: kvid <[email protected]>
    @formatc1702 @kvid
    formatc1702 and kvid committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    d9b67e4 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary check for length unit

    @formatc1702
    formatc1702 committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    e9292fb View commit details
    Browse the repository at this point in the history