Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Dev Overlay to Dev Toolbar #9271

Merged
merged 6 commits into from
Dec 1, 2023
Merged

Rename Dev Overlay to Dev Toolbar #9271

merged 6 commits into from
Dec 1, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Dec 1, 2023

Changes

  • All of the astro-dev-overlay-* custom elements are renamed to astro-dev-toolbar-*.
    • These are aliased back to astro-dev-overlay-* as to not break existing plugins.
  • addDevOverlayPlugin is renamed to addDevToolbarApp.
    • addDevOverlayPlugin remains as an alias.
  • devOverlay Config option renamed to devToolbar
  • devOverlay Astro preference renamed to devToolbar

Testing

  • Adds a few new tests, as well as updates the existing ones.

Docs

Copy link

changeset-bot bot commented Dec 1, 2023

⚠️ No Changeset found

Latest commit: f3a02b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 1, 2023
Copy link
Contributor

github-actions bot commented Dec 1, 2023

⚖️ Bundle Size Check

Latest commit: 3d2999b

File Old Size New Size Change
dev-overlay/entrypoint 85.51 KB 86.31 KB + 817 B
dev-overlay/overlay 40.32 KB 40.47 KB + 149 B
dev-overlay/plugins/astro 45.71 KB 45.71 KB 0 B
dev-overlay/plugins/audit 3.76 KB 3.76 KB 0 B
dev-overlay/plugins/settings 3.49 KB 3.49 KB 0 B
dev-overlay/plugins/utils/highlight 1005 B 1005 B 0 B
dev-overlay/plugins/utils/window 119 B 119 B 0 B
dev-overlay/plugins/xray 3.76 KB 3.76 KB 0 B
dev-overlay/ui-library/button 1.72 KB 1.76 KB + 39 B

@matthewp matthewp marked this pull request as ready for review December 1, 2023 20:50
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to log/warn users about using deprecated dev overlay stuff?

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/astro/src/integrations/index.ts Show resolved Hide resolved
@matthewp matthewp merged commit 47604bd into main Dec 1, 2023
15 checks passed
@matthewp matthewp deleted the dev-overlay-tests branch December 1, 2023 21:15
@astrobot-houston astrobot-houston mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants